X-Git-Url: http://dxcluster.net/gitweb/gitweb.cgi?a=blobdiff_plain;f=perl%2FDXProtHandle.pm;h=6f240200263758baaeb4b87a2b202fb35fdfa12e;hb=d0b21f21559a63d84086b549bb7570e2e16b75cd;hp=5189746aa5ba35f28e62f649c686618f6720d68b;hpb=d1d0a158e45ea7dba36caa70822d22bff7a9a00b;p=spider.git diff --git a/perl/DXProtHandle.pm b/perl/DXProtHandle.pm index 5189746a..6f240200 100644 --- a/perl/DXProtHandle.pm +++ b/perl/DXProtHandle.pm @@ -49,7 +49,7 @@ use vars qw($pc11_max_age $pc23_max_age $last_pc50 $eph_restime $eph_info_restim $eph_pc15_restime $pc9x_past_age $pc9x_dupe_age $pc10_dupe_age $pc92_slug_changes $last_pc92_slug $pc92Ain $pc92Cin $pc92Din $pc92Kin $pc9x_time_tolerance - $pc92filterdef $senderverify $pc11_dwell_time + $pc92filterdef $senderverify $pc11_dwell_time $pc61_extract_route $pc92_ad_enabled $pc92c_ipaddr_enabled ); $pc9x_dupe_age = 60; # catch loops of circular (usually) D records @@ -63,6 +63,7 @@ $pc9x_time_tolerance; # thing a node might send - once an hour and we $senderverify = 0; # 1 - check for forged PC11 or PC61. # 2 - if forged, dump them. $pc11_dwell_time = 2; # number of seconds to wait for a PC61 to come to substitute the PC11 +$pc61_extract_route = 0; # generate missing user route entry and IP address from passing PC61s $pc92filterdef = bless ([ @@ -140,7 +141,9 @@ sub handle_10 } # convert this to a PC93, coming from mycall with origin set and process it as such - $main::me->normal(pc93($to, $from, $via, $pc->[3], $pc->[6])); + my $ref = Route::get($pc->[6]); + my $ip = $ref->ip; + $main::me->normal(pc93($to, $from, $via, $pc->[3], $pc->[6]), $ip); } my %pc11_saved; # delayed PC11s @@ -167,9 +170,8 @@ sub handle_11 } } - my $type = - - dbg("INPUT $self->{call} -> $line origin $origin recurse: $recurse") if isdbg("pc11") || isdbg("pc61"); + dbg("---") if isdbg("pc11") || isdbg("pc61"); + dbg("INPUT $self->{call}: $line via: $origin recurse: $recurse") if isdbg("pc11") || isdbg("pc61"); # my ($hops) = $pc->[8] =~ /^H(\d+)/; @@ -257,50 +259,81 @@ sub handle_11 } } + my $rug = Route::User::get($pc->[6]); + if ($pcno == 61) { + unless ($pc->[8] && is_ipaddr($pc->[8])) { + LogDbg('err', "PCPROT: ROUTE $self->{call} NO IP ADDRESS in '$line'!"); + return; + } + if ($pc61_extract_route) { + $self->populate_routing_table($pc->[7], $pc->[6], $pc->[8]); + } + } # this is where we decide to delay PC11s in the hope that a PC61 will be along soon. - my $key = join '|', @spot[0..2,4,7]; # not including text unless ($recurse) { + if ($pcno == 61) { - if (Spot::dup_find(@spot[0..4,7])) { - dbg("DUPE $pc->[0] $self->{call} -> key: $key dumped") if isdbg('pc11'); - return; - } else { - ++$pc61_rx; - } if ($pc11_saved{$key}) { + # before we promote because it's a better pc61, check that it's not a dupe (but don't insert it). + if (Spot::dup_find(@spot[0..4,7])) { + dbg("PCPROT: Duplicate Spot $self->{call}: $pc->[0] $key ignored\n") if isdbg('chanerr') || isdbg('dupespot') || isdbg('pc11'); + delete $pc11_saved{$key}; + return; + } + ++$pc11_to_61; + my $percent = $pc11_rx ? $pc11_to_61 * 100 / $pc11_rx : 0; - dbg(sprintf("PROMOTED BETTER $self->{call} -> $pc->[0] $key, using PC61, saved PC11 DUMPED: $pc61_rx pc11: $pc11_rx better pc61: $pc11_to_61 (%0.1f%%)", $percent)) if isdbg("pc11"); - delete $pc11_saved{$key}; - } + dbg(sprintf("PROMOTED $self->{call}: BETTER $pc->[0] $key, using pc61, WAITING pc11 DUMPED: $pc61_rx pc11: $pc11_rx better pc61: $pc11_to_61 (%0.1f%%)", $percent)) if isdbg("pc11"); + + delete $pc11_saved{$key}; # because we have promoted it, no longer needed. + + # so unlike the promotion by route, there is a stored, but uncounted PC11 + # which have discarded. But we have chosen to use better PC61 that's just come in + # so we allow the PC61 to be counted later, but count the now discarded PC11 + # because it *did* come in. + ++$pc11_rx; + } } + if ($pcno == 11) { + # if this fires then we have already had one or more PC11s but no PC61 for this spot + if ($pc11_saved{$key}) { + dbg("DUPE $self->{call} $pc->[0] key: $key is saved, ignored") if isdbg("pc11"); + return; # because it's a dup + } + + # before we promote by route, check that it's not been preceded by a previous PC61 if (Spot::dup_find(@spot[0..4,7])) { - dbg("DUPE $pc->[0] $self->{call} -> key: $key dumped") if isdbg('pc11'); + my $s = exists $pc11_saved{$key} ? " stored $key removed" : ""; + dbg("PCPROT: Duplicate Spot $self->{call}: PC11$s, recurse: $recurse, ignored\n") if isdbg('chanerr') || isdbg('dupespot') || isdbg('pc11'); + delete $pc11_saved{$key}; return; - } else { - ++$pc11_rx; } - if ($pc11_saved{$key}) { - dbg("DUPE $pc->[0] $self->{call } key: is saved, ignored") if isdbg("pc11"); - return; # because it's a dup - } - # can we promote this to a PC61? - my $r = Route::User::get($spot[4]); # find spotter - if ($r && $r->ip) { # do we have an ip addres + # If we have an ip address we can promote by route + if ($rug && $rug->ip) { $pcno = 61; $pc->[0] = 'PC61'; - $pc->[7] = $spot[14] = $r->ip; + my $hops = $pc->[8]; + $pc->[8] = $spot[14] = $rug->ip; ++$rpc11_to_61; my $percent = $pc11_rx ? $rpc11_to_61 * 100 / $pc11_rx : 0; - dbg(sprintf("PROMOTED ROUTE $self->{call} -> PC11 $key PROMOTED to PC61 with IP $spot[14] pc61: $pc61_rx pc11: $pc11_rx route->pc61 $rpc11_to_61 (%0.1f%%)", $percent)) if isdbg("pc11"); + dbg(sprintf("PROMOTED $self->{call}: ROUTE pc11 $key PROMOTED to pc61 with IP $spot[14] pc61: $pc61_rx pc11: $pc11_rx route->pc61 $rpc11_to_61 (%0.1f%%)", $percent)) if isdbg("pc11"); + $line = join '^', @$pc, $hops, '~'; + + # update the stats (NOTE, thie record was a PC11, it has now become a PC61 + # this is NOT the same choosing a better PC61, that is a separate record. + ++$pc11_rx; # 'cos we received as a PC11 it and it won't be a pc11 anymore + --$pc61_rx; # 'cos we'll increment it later as it's now a pc61, no double counting + +# dbg("CHANGED saved key: $key PC11 line to $line") if isdbg('pc11'); delete $pc11_saved{$key}; } @@ -308,40 +341,42 @@ sub handle_11 # save it and wait - it will be called from pc11_process if ($pcno == 11) { $pc11_saved{$key} = [$main::systime, $self, $pcno, $line, $origin, $pc]; - dbg("SAVED $self->{call} -> NEW $pc->[0] spot $key waiting for a better offer") if isdbg("pc11"); + dbg("WAITING $self->{call}: NEW $pc->[0] spot $key waiting for a better offer") if isdbg("pc11"); return; } } } - - my $count = $pc11_to_61+$rpc11_to_61; - my $percent = $pc11_rx ? $count*100 / $pc11_rx : 0; - my $pc11_61 = $pc61_rx ? $pc11_rx*100 / $pc61_rx : 0; - dbg(sprintf("PASSED $self->{call} -> $pc->[0] spot $key, pc11: $pc11_rx pc61: $pc61_rx PC11/PC61 ratio: %0.1f%% total pc11->pc61: $count (%0.1f%%) ", $pc11_61, $percent)) if isdbg("pc11"); - # this goes after the input filtering, but before the add # so that if it is input filtered, it isn't added to the dup # list. This allows it to come in from a "legitimate" source + # + ## NOTE: this is where we insert the spot into the DXDupe cache + # if (Spot::dup(@spot[0..4,7])) { - dbg("PCPROT: Duplicate Spot $self->{call} -> $pc->[0] $key ignored\n") if isdbg('chanerr') || isdbg('dupespot') || isdbg('pc11'); + dbg("PCPROT: Duplicate Spot $self->{call}: $pc->[0] $key ignored\n") if isdbg('chanerr') || isdbg('dupespot') || isdbg('pc11'); return; } - dbg("PROCESSING $self->{call} -> $pc->[0] key: $key") if isdbg('pc11'); + dbg("PROCESSING $self->{call}: $pc->[0] key: $key") if isdbg('pc11'); - # we check IP addresses for PC61 - this will also dedupe PC11 copies + if ($pcno == 11) { + ++$pc11_rx; + } else { + ++$pc61_rx; + } + + # we check IP addresses for PC61 - this will also dedupe PC11 promotions if (@$pc > 8 && is_ipaddr($pc->[8])) { my $ip = $pc->[8]; $ip =~ s/,/:/g; $ip =~ s/^::ffff://; if (DXCIDR::find($ip)) { dbg($line) if isdbg('nologchan'); - dbg("PCPROT: $ip in badip list, dropped"); + dbg("PCPROT: PC61 $ip in badip list, dropped"); return; } } - # here we verify the spotter is currently connected to the node it says it is one. AKA email sender verify # but without the explicit probe to the node. We are relying on "historical" information, but it very likely @@ -349,23 +384,29 @@ sub handle_11 # # As for spots generated from non-PC92 nodes, we'll see after about do_pc9x3h20m... # - if ($senderverify) { + if ($senderverify || isdbg('suspicious')) { + my $sv = $senderverify; + $sv += 2 if isdbg('suspicious'); my $nroute = Route::Node::get($pc->[7]); - my $uroute = Route::Node::get($pc->[6]); my $local = DXChannel::get($pc->[7]); - + my $uref = DXUser::get_current($pc->[7]); + my $s = ''; + my $ip = $pcno == 61 ? $pc->[8] : ''; + if ($nroute && ($nroute->last_PC92C || ($local && !$local->do_pc9x))) { - my $s = ''; - my $ip = $pcno == 61 ? $pc->[8] : ''; # $s .= "User $pc->[6] not logged in, " unless $uroute; $s .= "User $pc->[6] not on node $pc->[7], " unless $nroute->is_user($pc->[6]); # $s .= "Node $pc->[7] at '$ip' not on Node's IP " . $nroute->ip if $ip && $nroute && $nroute->ip && $nroute->ip ne $ip; - if ($s) { - my $action = $senderverify > 1 ? ", DUMPED" : ''; - $s =~ s/, $//; - dbg("PCPROT: Suspicious Spot $pc->[2] on $pc->[1] by $pc->[6]($ip)\@$pc->[7] $s$action"); - return unless $senderverify < 2; - } + } + # check for ip addresses on spots from non-pc9x nodes - if they have it's likely done by DXSpider nodes + #if ($ip && ($nroute && !$nroute->do_pc9x || $uref && $uref->is_spider)) { + # $s .= "PC$pcno has spurious ipaddr '$ip' from non-pc9x node $pc->[7]"; + #} + if ($s) { + my $action = $sv > 1 ? ", DUMPED" : ''; + $s =~ s/, $//; + dbg("PCPROT: Bad Spot $pc->[2] on $pc->[1] by $pc->[6]($ip)\@$pc->[7] $s$action"); + return unless $sv < 2; } } @@ -467,16 +508,21 @@ sub handle_11 send_dx_spot($self, $line, @spot) if @spot; # cancel any recursion as we have now processed it + my $count = $pc11_to_61+$rpc11_to_61; + my $percent = ($pc11_rx + $pc61_rx) ? ($pc11_rx * 100) / ($pc11_rx + $pc61_rx) : 0; + my $pc11_61 = $pc11_rx ? ($count * 100) / $pc11_rx : 0; + my $data = "$pc->[0] key: $key"; + my $stats = sprintf "pc11: $pc11_rx pc61: $pc61_rx pc11%%: %0.1f%% pc11->pc61: $count(%0.1f%%)", $percent, $pc11_61; if ($recurse) { if ($pc11_saved{$key}) { - dbg("END RECURSED $self->{call} $pc->[0] key: $key removed and finished") if isdbg('pc11'); + dbg("END $self->{call}: RECURSED $data removed and finished $stats") if isdbg('pc11'); delete $pc11_saved{$key}; } else { - dbg("END RECURSED $self->{call} $pc->[0] key: $key finished") if isdbg('pc11'); + dbg("END $self->{call}: RECURSED NO KEY finished $stats") if isdbg('pc11'); } $recurse = 0; } else { - dbg("END NORMAL $self->{call} $pc->[0] key: $key finished") if isdbg('pc11'); + dbg("END $self->{call}: NORMAL $data finished $stats") if isdbg('pc11'); } } @@ -486,7 +532,8 @@ sub pc11_process foreach my $key (keys %pc11_saved) { my $r = $pc11_saved{$key}; if ($main::systime > $r->[0] + $pc11_dwell_time) { - dbg("SAVED PC11 spot $key timed out waiting, recursing") if isdbg("pc11"); + dbg("---") if isdbg("pc11"); + dbg("RECURSE $r->[1]->{call}: PC11 spot $key timed out waiting, resend") if isdbg("pc11"); my $self = $r->[1]; delete $pc11_saved{$key}; $self->handle_11(@$r[2..5], 1); @@ -494,6 +541,23 @@ sub pc11_process } } +# return the pc11 / pc61 / promotions data +sub get_pc11_61_stats +{ + my $promotions = $pc11_to_61+$rpc11_to_61; + my $percent = ($pc11_rx + $pc61_rx) ? ($pc11_rx * 100) / ($pc11_rx + $pc61_rx) : 0; + my $pc11_61p = $pc11_rx ? ($promotions * 100) / $pc11_rx : 0; + return { + pc11_rx => $pc11_rx+0, + pc61_rx => $pc61_rx+0, + pc11_to_61 => $pc11_to_61+0, + rpc11_to_61 => $rpc11_to_61+0, + promotions => $promotions+0, + pc11_percent => $percent+0, + promotions_percent => $pc11_61p+0, + }; +} + # announces sub handle_12 { @@ -677,23 +741,23 @@ sub handle_16 $conf = $conf eq '*'; # reject this if we think it is a node already - my $r = Route::Node::get($call); - my $u = DXUser::get_current($call) unless $r; - if ($r || ($u && $u->is_node)) { + my $rng = Route::Node::get($call); + my $u = DXUser::get_current($call) unless $rng; + if ($rng || ($u && $u->is_node)) { dbg("PCPROT: $call is a node") if isdbg('chanerr'); next; } - $r = Route::User::get($call); + my $rug = Route::User::get($call); my $flags = Route::here($here)|Route::conf($conf); - if ($r) { - my $au = $r->addparent($parent); - if ($r->flags != $flags) { - $r->flags($flags); - $au = $r; + if ($rug) { + my $au = $rug->addparent($parent); + if ($rug->flags != $flags) { + $rug->flags($flags); + $au = $rug; } - push @rout, $r if $h && $au; + push @rout, $rug if $h && $au; } else { my @ans = $parent->add_user($call, $flags); push @rout, @ans if $h && @ans; @@ -808,8 +872,10 @@ sub handle_18 my $parent = Route::Node::get($self->{call}); + my ($software, $version, $build) = (undef, 0, 0); + # record the type and version offered - if (my ($software, $version) = $pc->[1] =~ /(DXSpider|CC\s*Cluster)\s+Version: (\d+(?:\.\d+)?)/i) { + if (($software, $version) = $pc->[1] =~ /(DXSpider|CC\s*Cluster)\s+Version: (\d+(?:\.\d+)?)/i) { $version += 0; $version += 53 if $version < 6; $self->{version} = $version; @@ -817,6 +883,7 @@ sub handle_18 $parent->version($version); my ($build) = $pc->[1] =~ /Build: (\d+(?:\.\d+)?)/; $build += 0; + $build = 0 unless $build > 1; $self->{build} = $build; $self->user->build($build); $parent->build($build); @@ -828,6 +895,20 @@ sub handle_18 $self->sort('S'); } # $self->{handle_xml}++ if DXXml::available() && $pc->[1] =~ /\bxml/; + } elsif (($software, $version, $build) = $pc->[1] =~ /(AR-Cluster)\s+Version:\s+(\d+\.\d+).?(\d+\.\d+)?/) { + dbg("$self->{call} = $software version $version build $build"); + $self->{version} = $version; + $self->user->version($version); + $parent->version($version); + $self->{build} = $build; + $self->user->build($build); + $parent->build($build); + unless ($self->is_arcluster) { + dbg("Change U " . $self->user->sort . " C $self->{sort} -> R"); + $self->user->sort('R'); + $self->user->put; + $self->sort('R'); + } } else { dbg("$self->{call} = Unknown software ($pc->[1] $pc->[2])"); $self->version(50.0); @@ -835,7 +916,7 @@ sub handle_18 $self->user->version($self->version); } - if ($pc->[1] =~ /CC\*Cluster/i || $pc->[1] =~ /\bpc9x/i) { + if ($pc->[1] =~ /CC\s*Cluster/i || $pc->[1] =~ /\bpc9x/i) { if ($self->{isolate}) { dbg("$self->{call} pc9x recognised, but node is isolated, using old protocol"); } elsif (!$self->user->wantpc9x) { @@ -872,7 +953,7 @@ sub check_add_user $user->node($homenode); $user->priv(0); } - $user->lastin($main::systime); # this make it last longer than just this invocation + $user->lastin($main::systime); # this makes it last longer than just this invocation $user->put; # just to make sure it gets written away!!! dbg("DXProt: PC92 new user record for $call created"); } @@ -959,6 +1040,12 @@ sub handle_19 next; } + if ($call eq $main::myalias) { + LogDbg('err', "ROUTE: $call eq \$myalias from $self->{call}, ignored!!!"); + dbgprintring(3) if isdbg('nologchan'); + next; + } + my $user = check_add_user($call, 'A'); # if (eph_dup($genline)) { @@ -1734,7 +1821,12 @@ sub _add_thingy $user->del if $user; $call = $normcall; # this is safe because a route add will ignore duplicates } - + + if ($call eq $main::myalias && $is_node) { + LogDbg('err', "ROUTE: $call eq \$myalias from $ncall - downgraded to user!!!"); + dbgprintring(3) if isdbg('nologchan'); + $is_node = 0; + } if ($is_node) { dbg("ROUTE: added node $call to $ncall") if isdbg('routelow'); $user = check_add_user($call, 'A'); @@ -2176,7 +2268,9 @@ sub handle_92 dbg("PCPROT: $self->{call} : type $sort $_->[0] refers to me, ignored") if isdbg('route'); next; } - if ($_->[0] eq $main::myalias && $_->[1] || $_->[0] eq $main::mycall && $_->[1] == 0) { + + my $isnode = ($_->[1] | $_->[2]); + if (($_->[0] eq $main::myalias && $isnode) || ($_->[0] eq $main::mycall && !$isnode)) { LogDbg('err',"PCPROT: $self->{call} : type $sort $_->[0] trying to change type to " . $_->[1]?"Node":"User" . ", ignored"); next; } @@ -2250,7 +2344,10 @@ sub handle_92 $self->route_pc16($pcall, undef, $parent, @pc16) if @pc16; } - # broadcast it if we get here + # broadcast it if we get here (but not if it's an A or D record and pc92_ad_enabled isn't set; + if ($sort eq 'A' || $sort eq 'D') { + return unless $pc92_ad_enabled; + } $self->broadcast_route_pc9x($pcall, undef, $line, 0); } @@ -2318,7 +2415,11 @@ sub handle_93 my $via = uc $pc->[5]; my $text = $pc->[6]; my $onode = uc $pc->[7]; - $onode = $pcall if @$pc <= 8; + my $ipaddr = $pc->[8]; + + $onode = undef unless $onode && is_callsign($onode); + $onode //= $pcall; + $ipaddr = undef unless $ipaddr && is_ipaddr($ipaddr); # this is catch loops caused by bad software ... if (eph_dup("PC93|$from|$text|$onode", $pc10_dupe_age)) { @@ -2357,6 +2458,8 @@ sub handle_93 } } + $self->populate_routing_table($onode, $from, $ipaddr) if $pc61_extract_route; + # if it is routeable then then treat it like a talk my $ref = Route::get($to); if ($ref) { @@ -2435,4 +2538,49 @@ sub handle_default } } +# does what it says on the tin.. +sub populate_routing_table +{ + my ($self, $node, $user, $ip) = @_; + + my $rn = Route::Node::get($node); + unless ($rn) { + $rn = Route::Node->new($node); + dbg("ROUTE $self->{call}: ADD NEW node: $node") if isdbg('pc11'); + } + + my $ru; + if ($user ne $node) { + $ru = Route::User::get($user); + unless ($ru) { + $rn->add_user($user, 0, undef); + dbg("ROUTE $self->{call}: ADD NEW user: $user -> $node") if isdbg('pc11'); + } + $ru = Route::User::get($user); + } + + # Add/Change any IP address info + + # as we have a route to a user, if it (or the node) does not exist then create them + # link the user to the node if not already done. + # then add or alter the IP address + if ($ip && is_ipaddr($ip)) { + my $new = $ip; + if ($ru) { + if ($ru->ip ne $new) { + if ($ru->ip) { + my $old = $ru->ip; + $ru->ip($new); + dbg("ROUTE $self->{call}: ALTER IP node: $node user: $user old IP: '$old'-> new IP: '$new'") if isdbg('pc11'); + } else{ + $ru->ip($new); + dbg("ROUTE $self->{call}: NEW IP node: $node user: $user IP: '$new'") if isdbg('pc11'); + } + } + } else { + dbg("ROUTE $self->{call}: ADD Failed for node $node user $user") if isdbg('pc11'); + } + } +} + 1;