X-Git-Url: http://dxcluster.net/gitweb/gitweb.cgi?a=blobdiff_plain;f=perl%2FDXCron.pm;h=1337919790b910096944a800333339af2ce994a6;hb=bbf04d560516aeaff4899aa89fdf03aed5a80379;hp=9a3aac50495b80716f07a67e7efa93ee921ab04d;hpb=ed993b76a84e36b22efd1fc762d6a466497bcf7e;p=spider.git diff --git a/perl/DXCron.pm b/perl/DXCron.pm index 9a3aac50..13379197 100644 --- a/perl/DXCron.pm +++ b/perl/DXCron.pm @@ -73,17 +73,18 @@ sub cread my $ref = bless {}; my $err; - $err |= parse($ref, 'min', $min, 0, 60); - $err |= parse($ref, 'hour', $hour, 0, 23); - $err |= parse($ref, 'mday', $mday, 1, 31); - $err |= parse($ref, 'month', $month, 1, 12, "jan", "feb", "mar", "apr", "may", "jun", "jul", "aug", "sep", "oct", "nov", "dec"); - $err |= parse($ref, 'wday', $wday, 0, 6, "sun", "mon", "tue", "wed", "thu", "fri", "sat"); + $err .= parse($ref, 'min', $min, 0, 60); + $err .= parse($ref, 'hour', $hour, 0, 23); + $err .= parse($ref, 'mday', $mday, 1, 31); + $err .= parse($ref, 'month', $month, 1, 12, "jan", "feb", "mar", "apr", "may", "jun", "jul", "aug", "sep", "oct", "nov", "dec"); + $err .= parse($ref, 'wday', $wday, 0, 6, "sun", "mon", "tue", "wed", "thu", "fri", "sat"); if (!$err) { $ref->{cmd} = $cmd; push @out, $ref; dbg("DXCron::cread: adding $_\n") if isdbg('cron'); } else { - dbg("DXCron::cread: error on line $line '$_'\n") if isdbg('cron'); + $err =~ s/^, //; + dbg("DXCron::cread: error $err on line $line '$_'\n") if isdbg('cron'); } } close($fh); @@ -102,7 +103,7 @@ sub parse # handle '*' values if ($val eq '*') { $ref->{$sort} = 0; - return 0; + return; } # handle comma delimited values @@ -110,20 +111,20 @@ sub parse for (@comma) { my @minus = split /-/o; if (@minus == 2) { - return 1 if $minus[0] < $low || $minus[0] > $high; - return 1 if $minus[1] < $low || $minus[1] > $high; + return ", $sort should be $low >= $minus[0] <= $high" if $minus[0] < $low || $minus[0] > $high; + return ", $sort should be $low >= $minus[1] <= $high" if $minus[1] < $low || $minus[1] > $high; my $i; for ($i = $minus[0]; $i <= $minus[1]; ++$i) { push @req, 0 + $i; } } else { - return 1 if $_ < $low || $_ > $high; + return ", $sort should be $low >= $val <= $high" if $_ < $low || $_ > $high; push @req, 0 + $_; } } $ref->{$sort} = \@req; - return 0; + return; } # process the cronjobs @@ -266,7 +267,7 @@ sub spawn chomp; dbg("DXCron::spawn: $_") if isdbg("cron"); } - diffms("by DXCron::spawn", $line, $t0, scalar @res) if isdbg('chan'); + diffms("by DXCron::spawn", $line, $t0, scalar @res) if isdbg('progress'); } ); } @@ -296,7 +297,7 @@ sub spawn_cmd chomp; dbg("DXCron::spawn_cmd: $_") if isdbg("cron"); } - diffms("by DXCron::spawn_cmd", $line, $t0, scalar @res) if isdbg('chan'); + diffms("by DXCron::spawn_cmd", $line, $t0, scalar @res) if isdbg('progress'); } ); }