X-Git-Url: http://dxcluster.net/gitweb/gitweb.cgi?a=blobdiff_plain;f=cmd%2Fset%2Fbadip.pl;h=bfbd89ce505900423736986a449b4d568ff02ce0;hb=d3568fec5fb3e19f72dc4813dd2e18a7031dd6bb;hp=1ed8225adb050de98ac87e7d388860c8785125e6;hpb=2ef7a1dea1a74d743a7d806a58f97f55f90effcd;p=spider.git

diff --git a/cmd/set/badip.pl b/cmd/set/badip.pl
index 1ed8225a..bfbd89ce 100644
--- a/cmd/set/badip.pl
+++ b/cmd/set/badip.pl
@@ -21,6 +21,10 @@ if ($in[0] =~ /^[_\d\w]+$/) {
 return (1, "set/badip: need [suffix (def: local])] IP, IP-IP or IP/24") unless @in;
 for my $ip (@in) {
 	my $r;
+	unless (is_ipaddr($ip)) {
+		push @out, "set/badip: '$ip' is not an ip address, ignored";
+		next;
+	}
 	eval{ $r = DXCIDR::find($ip); };
 	return (1, "set/badip: $ip $@") if $@;
 	if ($r) {
@@ -34,6 +38,10 @@ my $count = @added;
 my $list = join ' ', @in;
 DXCIDR::clean_prep();
 #$DB::single = 1;
-DXCIDR::append($suffix, @added);
-push @out, "set/badip: added $count entries to badip.$suffix : $list" if $count;
+if ($count) {
+	DXCIDR::append($suffix, @added);
+	push @out, "set/badip: added $count entries to badip.$suffix : '$list'";
+} else {
+	push @out, "set/badip: No valid IPs, not updating badip.$suffix with '$list'";
+}
 return (1, @out);