fix filter error handling and error counting
[spider.git] / perl / Filter.pm
index 2be5cd5bbb48537ed6d7d05333b799389cbf8ba7..10021a4eada0e886660e65b44e699451bd8fb452 100644 (file)
@@ -31,6 +31,8 @@ use DXUtil;
 use DXDebug;
 use Data::Dumper;
 use Prefix;
+use DXLog;
+use DXJSON;
 
 use strict;
 
@@ -38,11 +40,13 @@ use vars qw ($filterbasefn $in);
 
 $filterbasefn = "$main::root/filter";
 $in = undef;
+my $json;
+
 
 # initial filter system
 sub init
 {
-
+       $json = DXJSON->new->indent(1);
 }
 
 sub new
@@ -88,6 +92,7 @@ sub compile
        if ($ref->{$ar} && exists $ref->{$ar}->{asc}) {
                my $s = $ref->{$ar}->{asc};     # an optimisation?
                $s =~ s/\$r/\$_[0]/g;
+#              $s =~ s/\\\\/\\/g;
                $ref->{$ar}->{code} = eval "sub { $s }" ;
                if ($@) {
                        my $sort = $ref->{sort};
@@ -109,7 +114,12 @@ sub read_in
        if ($fn = getfn($sort, $call, $flag)) {
                $in = undef; 
                my $s = readfilestr($fn);
-               my $newin = eval $s;
+               my $newin;
+               if ($s =~ /^\s*{/) {
+                       eval {$newin = $json->decode($s, __PACKAGE__)};
+               } else {        
+                       $newin = eval $s;
+               }
                if ($@) {
                        dbg($@);
                        unlink($fn);
@@ -136,6 +146,46 @@ sub read_in
        return undef;
 }
 
+
+# this writes out the filter in a form suitable to be read in by 'read_in'
+# It expects a list of references to filter lines
+sub write
+{
+       my $self = shift;
+       my $sort = $self->{sort};
+       my $name = $self->{name};
+       my $dir = "$filterbasefn/$sort";
+       my $fn = "$dir/$name";
+
+       mkdir $dir, 0775 unless -e $dir; 
+    rename $fn, "$fn.o" if -e $fn;
+       my $fh = new IO::File ">$fn";
+       if ($fh) {
+#              my $dd = new Data::Dumper([ $self ]);
+#              $dd->Indent(1);
+#              $dd->Terse(1);
+#              $dd->Quotekeys($] < 5.005 ? 1 : 0);
+               #               $fh->print($dd->Dumpxs);
+
+               # remove code references, do the encode, then put them back again (they can't be represented anyway)
+               my $key;
+               foreach $key ($self->getfilkeys) {
+                       $self->{$key}->{reject}->{code} = undef if exists $self->{$key}->{reject};
+                       $self->{$key}->{accept}->{code} = undef if exists $self->{$key}->{accept};
+               }
+               $fh->print($json->encode($self));
+               foreach $key ($self->getfilkeys) {
+                       $self->compile($key, 'reject');
+                       $self->compile($key, 'accept');
+               }
+               $fh->close;
+       } else {
+               rename "$fn.o", $fn if -e "$fn.o";
+               return "$fn $!";
+       }
+       return undef;
+}
+
 sub getfilters
 {
        my $self = shift;
@@ -208,7 +258,7 @@ sub it
                if ($filter->{reject} && exists $filter->{reject}->{code}) {
                        $type = 'reject';
                        $asc = $filter->{reject}->{user};
-                       if (&{$filter->{reject}->{code}}(\@_)) {
+                       if (&{$filter->{reject}->{code}}(ref $_[0] ? $_[0] : \@_)) {
                                $r = 0;
                                last;
                        } else {
@@ -218,7 +268,7 @@ sub it
                if ($filter->{accept} && exists $filter->{accept}->{code}) {
                        $type = 'accept';
                        $asc = $filter->{accept}->{user};
-                       if (&{$filter->{accept}->{code}}(\@_)) {
+                       if (&{$filter->{accept}->{code}}(ref $_[0] ? $_[0] : \@_)) {
                                $r = 1;
                                last;
                        } else {
@@ -231,44 +281,19 @@ sub it
        my $hops = $self->{hops} if exists $self->{hops};
 
        if (isdbg('filter')) {
-               my $args = join '\',\'', map {defined $_ ? $_ : 'undef'} @_;
+               my $call = $self->{name};
+               my $args = join '\',\'', map {defined $_ ? $_ : 'undef'} (ref $_[0] ? @{$_[0]} : @_);
                my $true = $r ? "OK " : "REJ";
                my $sort = $self->{sort};
                my $dir = $self->{name} =~ /^in_/i ? "IN " : "OUT";
-               
+
+               $call =~ s/\.PL$//i;
                my $h = $hops || '';
-               dbg("$true $dir: $type/$sort with $asc on '$args' $h") if isdbg('filter');
+               dbg("Filter: $call $true $dir: $type/$sort with '$asc' on '$args' $h") if isdbg('filter');
        }
        return ($r, $hops);
 }
 
-# this writes out the filter in a form suitable to be read in by 'read_in'
-# It expects a list of references to filter lines
-sub write
-{
-       my $self = shift;
-       my $sort = $self->{sort};
-       my $name = $self->{name};
-       my $dir = "$filterbasefn/$sort";
-       my $fn = "$dir/$name";
-
-       mkdir $dir, 0775 unless -e $dir; 
-    rename $fn, "$fn.o" if -e $fn;
-       my $fh = new IO::File ">$fn";
-       if ($fh) {
-               my $dd = new Data::Dumper([ $self ]);
-               $dd->Indent(1);
-               $dd->Terse(1);
-               $dd->Quotekeys($] < 5.005 ? 1 : 0);
-               $fh->print($dd->Dumpxs);
-               $fh->close;
-       } else {
-               rename "$fn.o", $fn if -e "$fn.o";
-               return "$fn $!";
-       }
-       return undef;
-}
-
 sub print
 {
        my $self = shift;
@@ -351,6 +376,8 @@ sub delete
        }
 }
 
+
+
 package Filter::Cmd;
 
 use strict;
@@ -360,6 +387,21 @@ use DXDebug;
 use vars qw(@ISA);
 @ISA = qw(Filter);
 
+sub encode_regex
+{
+       my $s = shift;
+       $s =~ s/\{(.*?)\}/'{'. unpack('H*', $1) . '}'/eg if $s;
+       return $s;
+}
+
+sub decode_regex
+{
+       my $r = shift;
+       my ($v) = $r =~ /^\{(.*?)}$/;
+       return pack('H*', $v);
+}
+
+
 # the general purpose command processor
 # this is called as a subroutine not as a method
 sub parse
@@ -370,19 +412,27 @@ sub parse
        my $filter;
        my ($flag, $call);
        my $s;
-       my $user;
+       my $user = '';
        
        # check the line for non legal characters
        dbg("Filter::parse line: '$line'") if isdbg('filter');
-       return ('ill', $dxchan->msg('e19')) if $line !~ /{.*}/ && $line =~ /[^\s\w,_\-\*\/\(\)\$!]/;
+       my @ch = $line =~ m|([^\s\w,_\.:\/\-\*\(\)\$!])|g;
+       return ('ill', $dxchan->msg('e19', join(' ', @ch))) if $line !~ /{.*}/ && @ch;
+
+       $line = lc $line;
+
+       # disguise regexes
+
+       dbg("Filter parse line after regex check: '$line'") if isdbg('filter');
+       $line = encode_regex($line);
        
        # add some spaces for ease of parsing
-       $line =~ s/([\(\)])/ $1 /g;
-       $line = lc $line;
+       $line =~ s/([\(\!\)])/ $1 /g;
        
        my @f = split /\s+/, $line;
-       my $conj = ' && ';
-       my $not = "";
+       dbg("filter parse: tokens '" . join("' '", @f) . "'") if isdbg('filter');
+       
+       my $lasttok = '';
        while (@f) {
                if ($ntoken == 0) {
                        
@@ -410,57 +460,30 @@ sub parse
                # do the rest of the filter tokens
                if (@f) {
                        my $tok = shift @f;
-                       if ($tok eq '(') {
-                               if ($s) {
-                                       $s .= $conj;
-                                       $user .= $conj;
-                                       $conj = "";
-                               }
-                               if ($not) {
-                                       $s .= $not;
-                                       $user .= $not;
-                                       $not = "";
-                               }
-                               $s .= $tok;
-                               $user .= $tok;
-                               next;
-                       } elsif ($tok eq ')') {
-                               $conj = ' && ';
-                               $not ="";
-                               $s .= $tok;
-                               $user .= $tok;
-                               next;
-                       } elsif ($tok eq 'all') {
+
+                       dbg("filter::parse: tok '$tok'") if isdbg('filter');
+                       
+                       if ($tok eq 'all') {
                                $s .= '1';
                                $user .= $tok;
                                last;
-                       } elsif ($tok eq 'or') {
-                               $conj = ' || ' if $conj ne ' || ';
-                               next;
-                       } elsif ($tok eq 'and') {
-                               $conj = ' && ' if $conj ne ' && ';
+                       } elsif (grep $tok eq $_, qw{and or not ( )}) {
+                               $s .= ' && ' if $tok eq 'and';
+                               $s .= ' || ' if $tok eq 'or';
+                               $s .= ' !' if $tok eq 'not';
+                               $s .=  $tok if $tok eq '(' or $tok eq ')';
+                               $user .= " $tok ";
                                next;
-                       } elsif ($tok eq 'not' || $tok eq '!') {
-                               $not = '!';
+                       } elsif ($tok eq '') {
                                next;
                        }
+                       
                        if (@f) {
                                my $val = shift @f;
                                my @val = split /,/, $val;
 
-                               if ($s) {
-                                       $s .= $conj ;
-                                       $user .= $conj;
-                                       $conj = ' && ';
-                               }
-
-                               if ($not) {
-                                       $s .= $not;
-                                       $user .= $not;
-                                       $not = '';
-                               }
-
-                               $user .= "$tok $val";
+                               dbg("filter::parse: tok '$tok' val '$val'") if isdbg('filter');
+                               $user .= " $tok $val";
                                
                                my $fref;
                                my $found;
@@ -476,16 +499,21 @@ sub parse
                                                }
                                                if ($fref->[1] eq 'a' || $fref->[1] eq 't') {
                                                        my @t;
-                                                       for (@val) {
-                                                               s/\*//g;        # remove any trailing *
-                                                               if (/^\{.*\}$/) { # we have a regex 
-                                                                       s/^\{//;
-                                                                   s/\}$//;
-                                                                       return  ('regex', $dxchan->msg('e38', $_)) unless (qr{$_})
+                                                       foreach my $v (@val) {
+                                                               $v =~ s/\*//g;        # remove any trailing *
+                                                               if (my ($r) = $v =~ /^\{(.*)\}$/) { # we have a regex
+                                                                       dbg("Filter::parse regex b: '\{$r\}'") if isdbg('filter'); 
+                                                                       $v = decode_regex($v);
+                                                                       dbg("Filter::parse regex a: '$v'") if isdbg('filter'); 
+                                                                       return  ('regex', $dxchan->msg('e38', $v)) unless (qr{$v});
+                                                                       push @t, "\$r->[$fref->[2]]=~m{$v}i";
+                                                                       $v = "{$r}"; # put it back together again for humans
+                                                               } else {
+                                                                       push @t, "\$r->[$fref->[2]]=~m{$v}i";
                                                                }
-                                                               push @t, "\$r->[$fref->[2]]=~m{$_}i";
                                                        }
                                                        $s .= "(" . join(' || ', @t) . ")";
+                                                       dbg("filter parse: s '$s'") if isdbg('filter');
                                                } elsif ($fref->[1] eq 'c') {
                                                        my @t;
                                                        for (@val) {
@@ -493,6 +521,7 @@ sub parse
                                                                push @t, "\$r->[$fref->[2]]=~m{^\U$_}";
                                                        }
                                                        $s .= "(" . join(' || ', @t) . ")";
+                                                       dbg("filter parse: s '$s'") if isdbg('filter');
                                                } elsif ($fref->[1] eq 'n') {
                                                        my @t;
                                                        for (@val) {
@@ -500,16 +529,19 @@ sub parse
                                                                push @t, "\$r->[$fref->[2]]==$_";
                                                        }
                                                        $s .= "(" . join(' || ', @t) . ")";
+                                                       dbg("filter parse: s '$s'") if isdbg('filter');
                                                } elsif ($fref->[1] =~ /^n[ciz]$/ ) {    # for DXCC, ITU, CQ Zone    
                                                        my $cmd = $fref->[1];
                                                        my @pre = Prefix::to_ciz($cmd, @val);
                                                        return ('numpre', $dxchan->msg('e27', $_)) unless @pre;
                                                        $s .= "(" . join(' || ', map {"\$r->[$fref->[2]]==$_"} @pre) . ")";
+                                                       dbg("filter parse: s '$s'") if isdbg('filter');
                                                } elsif ($fref->[1] =~ /^ns$/ ) {    # for DXCC, ITU, CQ Zone    
                                                        my $cmd = $fref->[1];
                                                        my @pre = Prefix::to_ciz($cmd, @val);
                                                        return ('numpre', $dxchan->msg('e27', $_)) unless @pre;
                                                        $s .= "(" . "!\$USDB::present || grep \$r->[$fref->[2]] eq \$_, qw(" . join(' ' ,map {uc} @pre) . "))";
+                                                       dbg("filter parse: s '$s'") if isdbg('filter');
                                                } elsif ($fref->[1] eq 'r') {
                                                        my @t;
                                                        for (@val) {
@@ -517,6 +549,7 @@ sub parse
                                                                push @t, "(\$r->[$fref->[2]]>=$1 && \$r->[$fref->[2]]<=$2)";
                                                        }
                                                        $s .= "(" . join(' || ', @t) . ")";
+                                                       dbg("filter parse: s '$s'") if isdbg('filter');
                                                } else {
                                                        confess("invalid filter function $fref->[1]");
                                                }
@@ -524,19 +557,32 @@ sub parse
                                                last;
                                        }
                                }
-                               return ('unknown', $dxchan->msg('e20', $tok)) unless $found;
+                               return (1, $dxchan->msg('e20', $lasttok)) unless $found;
                        } else {
-                               return ('no', $dxchan->msg('filter2', $tok));
+                               $s = $tok =~ /^{.*}$/ ? '{' . decode_regex($tok) . '}' : $tok;
+                               return (1, $dxchan->msg('filter2', $s));
                        }
+                       $lasttok = $tok;
                }
-               
        }
 
-       # tidy up the user string
-       $user =~ s/\&\&/ and /g;
-       $user =~ s/\|\|/ or /g;
-       $user =~ s/\!/ not /g;
-       $user =~ s/\s+/ /g;
+       # tidy up the user string (why I have to stick in an if statement when I have initialised it I have no idea! 5.28 bug?
+       if ($user) {
+               $user =~ s/\)\s*\(/ and /g;
+               $user =~ s/\&\&/ and /g;
+               $user =~ s/\|\|/ or /g;
+               $user =~ s/\!/ not /g;
+               $user =~ s/\s+/ /g;
+               $user =~ s/\{(.*?)\}/'{'. pack('H*', $1) . '}'/eg;
+               $user =~ s/^\s+//;
+               dbg("filter parse: user '$user'") if isdbg('filter');
+       }
+
+       if ($s) {
+               $s =~ s/\)\s*\(/ && /g;
+               dbg("filter parse: s '$s'") if isdbg('filter');
+       }
+
        
        return (0, $filter, $fno, $user, $s);
 }
@@ -545,13 +591,13 @@ sub parse
 sub cmd
 {
        my ($self, $dxchan, $sort, $type, $line) = @_;
-       
        return $dxchan->msg('filter5') unless $line;
 
        my ($r, $filter, $fno, $user, $s) = $self->parse($dxchan, $sort, $line);
+       return (1, $filter) if $r;
+       
        my $u = DXUser::get_current($user);
        return (1, $dxchan->msg('isow', $user)) if $u && $u->isolate;
-       return (1, $filter) if $r;
 
        my $fn = "filter$fno";
 
@@ -560,12 +606,13 @@ sub cmd
 
        $filter->{$fn}->{$type}->{user} = $user;
        $filter->{$fn}->{$type}->{asc} = $s;
-       $r = $filter->compile($fn, $type);
-       return (1,$r) if $r;
+       $r = $filter->compile($fn, $type);   # NOTE: returns an ERROR, therefore 0 = success
+       return (0,$r) if $r;
        
        $r = $filter->write;
        return (1,$r) if $r;
-       
+
+       $filter->install(1);            # 'delete'
        $filter->install;
 
     return (0, $filter, $fno);