remove shadow $i

[spider.git] / perl / DXProtout.pm

diff --git a/perl/DXProtout.pm b/perl/DXProtout.pm
index 47d44c92c339e39a58c8b6076dfaf894619a57e9..42c995510c2c265d6bf8aa52b0bbc91a4e5945a0 100644 (file)
--- a/perl/DXProtout.pm
+++ b/perl/DXProtout.pm
@@ -76,17 +76,17 @@ sub pc16
 {
        my $self = shift;
        my @out;
+       my $i;
 
-       foreach (@_) {
+       for ($i = 0; @_; ) {
                my $str = "PC16^$self->{call}";
-               my $i;
-    
-               for ($i = 0; @_ > 0  && $i < $DXProt::pc16_max_users; $i++) {
+               for ( ; @_ && $i < $DXProt::pc16_max_users; $i++) {
                        my $ref = shift;
                        $str .= sprintf "^%s %s %d", $ref->call, $ref->confmode ? '*' : '-', $ref->here;
                }
                $str .= sprintf "^%s^", get_hops(16);
                push @out, $str;
+               $i = 0;
        }
        return (@out);
 }
@@ -102,8 +102,7 @@ sub pc17
 # Request init string
 sub pc18
 {
-       my $info = DXCluster::cluster;
-       return "PC18^$info^$DXProt::myprot_version^";
+       return "PC18^DXSpider Version: $main::version Build: $main::build^$DXProt::myprot_version^";
 }
 
 #
@@ -113,12 +112,12 @@ sub pc19
 {
        my $self = shift;
        my @out;
+       my $i;
+       
 
-       while (@_) {
+       for ($i = 0; @_; ) {
                my $str = "PC19";
-               my $i;
-    
-               for ($i = 0; @_ && $i < $DXProt::pc19_max_nodes; $i++) {
+               for (; @_ && $i < $DXProt::pc19_max_nodes; $i++) {
                        my $ref = shift;
                        my $here = $ref->{here} ? '1' : '0';
                        my $confmode = $ref->{confmode} ? '1' : '0';
@@ -126,6 +125,7 @@ sub pc19
                }
                $str .= sprintf "^%s^", get_hops(19);
                push @out, $str;
+               $i = 0;
        }
        return @out;
 }