make PC19 & 16 generation more efficient on receipt of PC92

[spider.git] / perl / DXProtHandle.pm

diff --git a/perl/DXProtHandle.pm b/perl/DXProtHandle.pm
index 26781885eb318f38292b2a9d1858c6549614ddc1..9e5d249f33e9af00fed07ce032c3be65b4aafbab 100644 (file)
--- a/perl/DXProtHandle.pm
+++ b/perl/DXProtHandle.pm
@@ -1339,10 +1339,10 @@ sub gen_pc9x_t
        if (!$_last_time || $_last_time != $main::systime) {
                $_last_time = $main::systime;
                $_last_occurs = 0;
-               return $_last_time;
+               return $_last_time - $main::systime_daystart;
        } else {
                $_last_occurs++;
-               return sprintf "$_last_time.%02d", $_last_occurs;
+               return sprintf "%d.%02d", $_last_time - $main::systime_daystart, $_last_occurs;
        }
 }
 
@@ -1356,10 +1356,12 @@ sub check_pc9x_t
        my $parent = ref $call ? $call : Route::Node::get($call);
        if ($parent) {
                my $lastid = $parent->lastid->{$pc} || 0;
+               $t += 86400 if $t < $lastid - 43200;
                if ($lastid >= $t) {
                        dbg("PCPROT: dup / old id on $call <= $lastid, ignored") if isdbg('chanerr');
                        return;
                }
+               $t -= 86400 if $t >= 86400;
        } elsif ($create) {
                $parent = Route::Node->new($call);
        }
@@ -1393,7 +1395,7 @@ sub handle_92
                return;
        }
 
-       my $parent = check_pc9x_t($pcall, $t, 92, 1);
+       my $parent = check_pc9x_t($pcall, $t, 92, 1) || return;
        
        $parent->lastid->{92} = $t;
        $parent->do_pc92(1);
@@ -1404,6 +1406,10 @@ sub handle_92
                # and update any information that needs to be done. 
                my ($call, $is_node, $is_extnode, $here, $version, $build) = _decode_pc92_call($ent[0]);
                if ($call && $is_node) {
+                       if ($call eq $main::mycall) {
+                               dbg("PCPROT: looped back on node entry, ignored") if isdbg('chanerr');
+                               return;
+                       }
                        if ($is_extnode) {
                                # reparent to external node (note that we must have received a 'C' or 'A' record
                                # from the true parent node for this external before we get one for the this node
@@ -1469,12 +1475,10 @@ sub handle_92
                $self->route_pc21($pcall, undef, $r) if $r->isa('Route::Node');
                $self->route_pc17($pcall, undef, $parent, $r) if $r->isa('Route::User');
        }
-       foreach my $r (@radd) {
-               next unless $r;
-
-               $self->route_pc19($pcall, undef, $r) if $r->isa('Route::Node');
-               $self->route_pc16($pcall, undef, $parent, $r) if $r->isa('Route::User');
-       }
+       my @pc19 = grep { $_ && $_->isa('Route::Node') } @radd;
+       my @pc16 = grep { $_ && $_->isa('Route::User') } @radd;
+       $self->route_pc19($pcall, undef, @pc19) if @pc19;
+       $self->route_pc16($pcall, undef, $parent, @pc16) if @pc16;
 }
 
 # if get here then rebroadcast the thing with its Hop count decremented (if