kill some 5.28 warnings

[spider.git] / perl / DXCron.pm

diff --git a/perl/DXCron.pm b/perl/DXCron.pm
index b0d4b1c6dc6609c158cd3568cd5ce2e168f9ce9b..c31e46f51d9a4ea47fdc4c885e03ead835ce4d47 100644 (file)
--- a/perl/DXCron.pm
+++ b/perl/DXCron.pm
@@ -64,14 +64,14 @@ sub cread
 
        dbg("DXCron::cread reading $fn\n") if isdbg('cron');
        open($fh, $fn) or confess("cron: can't open $fn $!");
-       while (<$fh>) {
+       while (my $l = <$fh>) {
                $line++;
-               chomp;
-               next if /^\s*#/o or /^\s*$/o;
-               my ($min, $hour, $mday, $month, $wday, $cmd) = /^\s*(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(.+)$/o;
+               chomp $l;
+               next if $l =~ /^\s*#/o or $l =~ /^\s*$/o;
+               my ($min, $hour, $mday, $month, $wday, $cmd) = $l =~ /^\s*(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(.+)$/o;
                next unless defined $min;
                my $ref = bless {};
-               my $err;
+               my $err = '';
 
                if (defined $min && defined $hour && defined $cmd) { # it isn't all of them, but should be enough to tell if this is a real line
                        $err .= parse($ref, 'min', $min, 0, 60);
@@ -82,18 +82,17 @@ sub cread
                        if (!$err) {
                                $ref->{cmd} = $cmd;
                                push @out, $ref;
-                               dbg("DXCron::cread: adding $_\n") if isdbg('cron');
+                               dbg("DXCron::cread: adding $l\n") if isdbg('cron');
                        } else {
                                $err =~ s/^, //;
-                               LogDbg('cron', "DXCron::cread: error $err on line $line '$_'");
+                               LogDbg('cron', "DXCron::cread: error $err on line $line '$l'");
                        }
                } else {
-                       LogDbg('cron', "DXCron::cread error on line $line '$_'");
+                       LogDbg('cron', "DXCron::cread error on line $line '$l'");
                        my @s = ($min, $hour, $mday, $month, $wday, $cmd);
                        my $s = "line $line splits as " . join(', ', (map {defined $_ ? qq{$_} : q{'undef'}} @s));
                        LogDbg('cron', $s);
                }
-               
        }
        close($fh);
        return @out;